Skip to content

Conversation

@leecalcote
Copy link
Contributor

@leecalcote leecalcote commented Jun 13, 2016

Fix regression respectively introduced in 59ede1a and 59ede1a

The config-schema.json and state-schema.json references were missing "-schema".

@wking
Copy link
Contributor

wking commented Jun 13, 2016

On Mon, Jun 13, 2016 at 04:07:49PM -0700, Lee Calcote wrote:

The config-schema.json and state-schema.json references were missing
"-schema".

Oops, busted reroll in #481 :/. 644b888 is missing a Signed-off-by
[1,2], but other than that it looks good to me.

@jcfr
Copy link

jcfr commented Jun 17, 2016

@leecalcote

Nitpicks: May be you could amend and update the title/message to provide more context ?

schema/README: Fix links to (config|state)-schema.json

Fix regression respectively introduced in 59ede1a and 59ede1a

@leecalcote leecalcote changed the title fixed two broken references schema/README: Fix links to (config|state)-schema.json Jun 17, 2016
@wking
Copy link
Contributor

wking commented Jun 17, 2016

On Fri, Jun 17, 2016 at 10:31:58AM -0700, Jean-Christophe Fillion-Robin wrote:

schema/README: Fix links to (config|state)-schema.json

Pushing this as a commit-message summary would be nice too, but that's
not a big deal. And e319b85 looks good to me otherwise.

Fix regression respectively introduced in 59ede1a and 59ede1a

The config-schema.json and state-schema.json references were missing "-schema".

Signed-off-by: Lee Calcote <[email protected]>
@leecalcote
Copy link
Contributor Author

I just did a git commit --amend and git push --force on this patch with a revised message subject and summary.

@jcfr
Copy link

jcfr commented Jun 17, 2016

🎱

@vbatts
Copy link
Member

vbatts commented Jun 20, 2016

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Jun 21, 2016

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 1c48651 into opencontainers:master Jun 21, 2016
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Jul 19, 2016
This slipped through the rename in 2a5986f (schema/state-schema.json:
Add a JSON Schema for the state JSON, 2016-06-01, opencontainers#481) and the first
round of fixes in dfb85b1 (schema/README: Fix links to
(config|state)-schema.json, 2016-06-13, opencontainers#498).  Reported by hapnermw
[1].

[1]: opencontainers#517

Signed-off-by: W. Trevor King <[email protected]>
Mashimiao pushed a commit to Mashimiao/specs that referenced this pull request Aug 19, 2016
This slipped through the rename in 2a5986f (schema/state-schema.json:
Add a JSON Schema for the state JSON, 2016-06-01, opencontainers#481) and the first
round of fixes in dfb85b1 (schema/README: Fix links to
(config|state)-schema.json, 2016-06-13, opencontainers#498).  Reported by hapnermw
[1].

[1]: opencontainers#517

Signed-off-by: W. Trevor King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants